icecat: add release icecat-140.10.1-1gnu1 for ecne

icecat/extensions/permissions/test/unit/test_permmanager_expiration.js

@@ -23,20 +23,21 @@ function* do_run_test() {
 
   let now = Number(Date.now());
 
-  // add a permission with *now* expiration
+  // add a permission with *now* expiration (minus 10ms to ensure timing doesn't
+  // treat them as still valid)
   pm.addFromPrincipal(
     principal,
     "test/expiration-perm-exp",
     1,
     pm.EXPIRE_TIME,
-    now
+    now - 10
   );
   pm.addFromPrincipal(
     principal,
     "test/expiration-session-exp",
     1,
     pm.EXPIRE_SESSION,
-    now
+    now - 10
   );
 
   // add a permission with future expiration (100 milliseconds)

icecat/extensions/spellcheck/ipc/RemoteSpellCheckEngineChild.cpp

@@ -14,7 +14,17 @@ RemoteSpellcheckEngineChild::RemoteSpellcheckEngineChild(
 RemoteSpellcheckEngineChild::~RemoteSpellcheckEngineChild() {
   // null out the owner's SpellcheckEngineChild to prevent state corruption
   // during shutdown
-  mOwner->DeleteRemoteEngine();
+  if (mOwner) {
+    mOwner->DeleteRemoteEngine();
+  }
+}
+
+void RemoteSpellcheckEngineChild::Destroy() {
+  if (mOwner) {
+    mOwner->DeleteRemoteEngine();
+    mOwner = nullptr;
+  }
+  (void)RemoteSpellcheckEngineChild::Send__delete__(this);
 }
 
 RefPtr<GenericPromise> RemoteSpellcheckEngineChild::SetCurrentDictionaries(

icecat/extensions/spellcheck/ipc/RemoteSpellCheckEngineChild.h

@@ -17,8 +17,11 @@ class RemoteSpellcheckEngineChild
     : public mozilla::PRemoteSpellcheckEngineChild {
  public:
   explicit RemoteSpellcheckEngineChild(mozSpellChecker* aOwner);
+  RemoteSpellcheckEngineChild() = delete;
   virtual ~RemoteSpellcheckEngineChild();
 
+  void Destroy();
+
   RefPtr<GenericPromise> SetCurrentDictionaries(
       const nsTArray<nsCString>& aDictionaries);
 

icecat/extensions/spellcheck/src/mozSpellChecker.cpp

@@ -42,7 +42,7 @@ mozSpellChecker::~mozSpellChecker() {
 
   if (mEngine) {
     MOZ_ASSERT(XRE_IsContentProcess());
-    RemoteSpellcheckEngineChild::Send__delete__(mEngine);
+    mEngine->Destroy();
     MOZ_ASSERT(!mEngine);
   }
 }